Add althea payments test #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptulugu
force-pushed
the
pranay/althea_blockchain
branch
2 times, most recently
from
724538b
to
b8a63c8
Compare
ptulugu
force-pushed
the
pranay/althea_blockchain
branch
2 times, most recently
from
176152d
to
331525e
Compare
jkilpatr
requested changes
Jul 10, 2023
…or payment modules This commit includes a simple test to test an althea chain payments between two nodes. It includes various bug fixes and improvements for payment validator/controller: 1.) Generate althea private key using .into() 2.) Send microtx with a wait timeout of 30 sec 3.) Uint256::from_str_radix instead of parse() on althea hash 4.) Hold a write lock for the entire validate_later flow to prevent double payments 5.) Separate validation flows for althea and eth payments
ptulugu
force-pushed
the
pranay/althea_blockchain
branch
from
331525e
to
79185f8
Compare
jkilpatr
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup a simple test for althea payments as well as varous bug fixes for payment modules
This commit includes a simple test to test an althea chain payments between two nodes.
It includes various bug fixes and improvements for payment validator/controller:
1.) Generate althea private key using .into()
2.) Send microtx with a wait timeout of 30 sec
3.) Uint256::from_str_radix instead of parse() on althea hash
4.) Hold a write lock for the entire validate_later flow to prevent double payments
5.) Separate validation flows for althea and eth payments